Warn when an invalid role is provided for wp user update#406
Merged
danielbachhuber merged 6 commits intowp-cli:mainfrom May 30, 2023
Merged
Warn when an invalid role is provided for wp user update#406danielbachhuber merged 6 commits intowp-cli:mainfrom
wp user update#406danielbachhuber merged 6 commits intowp-cli:mainfrom
Conversation
- Added $warn_user_only parameter in the validate_role() function.
Member
danielbachhuber
left a comment
There was a problem hiding this comment.
Can you include some feature tests for this change? Here is some guidance on our pull request best practices, if it's helpful.
Contributor
Author
Yes sure. |
Contributor
Author
|
@danielbachhuber Other than the tests is solution right? |
Member
@SH4LIN Yes, I think it's fine. It looks like the existing tests are passing, too. |
Contributor
Author
|
@danielbachhuber I have added the functional test can you check it? |
Contributor
Author
|
@danielbachhuber Can you check if the Functional tests are okay? |
wp user update
Member
@SH4LIN The functional tests look great! Thanks for improving them 😊 |
danielbachhuber
approved these changes
May 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #160