Do not mark main site as spam when using 'wp user spam'#393
Merged
danielbachhuber merged 4 commits intowp-cli:mainfrom Mar 15, 2023
Merged
Do not mark main site as spam when using 'wp user spam'#393danielbachhuber merged 4 commits intowp-cli:mainfrom
danielbachhuber merged 4 commits intowp-cli:mainfrom
Conversation
danielbachhuber
approved these changes
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user has a role on the main site and we use
wp user spamon that user, the main site will be marked as spam.It looks like the following commit broke the main site check: 60f91b3. Commit 1bc55d0 fixes this by using
is_main_site().I've also removed the call to
use WP_CLI\Fetchers\Site as SiteFetcherin commit 5f4b7e1 since it doesn't appear to be necessary.I haven't written a behat test for this yet, but feel free to do so.