Add wp option get-autoload and wp option set-autoload#382
Merged
danielbachhuber merged 5 commits intomasterfrom Nov 15, 2022
Merged
Add wp option get-autoload and wp option set-autoload#382danielbachhuber merged 5 commits intomasterfrom
wp option get-autoload and wp option set-autoload#382danielbachhuber merged 5 commits intomasterfrom
Conversation
schlessera
requested changes
Nov 10, 2022
Comment on lines
+479
to
+480
| * - 'yes' | ||
| * - 'no' |
Member
There was a problem hiding this comment.
This means the API is:
wp option set-autoload my_option no
That seems to be forced by the DB value and is neither developer-speak (set autoload true) nor natural language (disable autoload).
I'm don't love that API, but I have trouble coming up with something better.
What do think about:
wp option autoload get my_option
wp option autoload enable my_option
wp option autoload disable my_option
Member
Author
There was a problem hiding this comment.
I'm don't love that API, but I have trouble coming up with something better.
What do think about:
@schlessera Good points. I don't love your proposed approach either because it seems unnecessarily complex to nest the commands further.
I went with wp option set-autoload my_option no because wp option add accepts --autoload=yes/--autoload=no.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
wp option get-autoloadandwp option set-autoloadcommands:These are useful for manipulating the
autoloadvalue.wp option updatecan't be used for this directly becauseupdate_option()won't changeautoloadif thevaluedoesn't change.Recreates the cache manipulation inside of
update_option()too: https://github.com/WordPress/wordpress-develop/blob/04e8bb4bb5ed37dade1b1ddda634e45f7503820d/src/wp-includes/option.php#L525-L540This feels brittle, but not sure there's a better way around it...