Use current_time() for setting the default value for user_registered in wp user create#378
Merged
danielbachhuber merged 2 commits intowp-cli:masterfrom Oct 3, 2022
jorgeatorres:master
Merged
Use current_time() for setting the default value for user_registered in wp user create#378danielbachhuber merged 2 commits intowp-cli:masterfrom jorgeatorres:master
current_time() for setting the default value for user_registered in wp user create#378danielbachhuber merged 2 commits intowp-cli:masterfrom
jorgeatorres:master
Conversation
danielbachhuber
approved these changes
Oct 3, 2022
Member
danielbachhuber
left a comment
There was a problem hiding this comment.
Looks great, thanks @jorgeatorres ! I appreciate your detailed description 😊
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #377, by relying on
current_time()instead ofdate_format()to properly produce a default value foruser_registeredwhen creating users viawp user create.I've also included a behat test that should fail in
master(but not on this branch).Note: I did a quick search through the org and this seems to be the only place where we were using
date_format()with an invalid format.Steps to test
master.wp user create testuser testuser@example.com.wp user get testusershows0000-00-00 00:00:00as the value for theuser_registeredfield.wp user delete testuser.user_registeredfield.Closes #377.