Skip to content

Support filtering for users without a role with --role=none#360

Merged
danielbachhuber merged 5 commits intowp-cli:masterfrom
BhargavBhandari90:issue-34
Aug 22, 2022
Merged

Support filtering for users without a role with --role=none#360
danielbachhuber merged 5 commits intowp-cli:masterfrom
BhargavBhandari90:issue-34

Conversation

@BhargavBhandari90
Copy link
Contributor

@BhargavBhandari90 BhargavBhandari90 commented Aug 14, 2022

Fixes #34

Allow getting users with no role by using the following command

wp user list --role=none

Waiting for clarification #34 (comment)

@BhargavBhandari90 BhargavBhandari90 requested a review from a team as a code owner August 14, 2022 10:49
@BhargavBhandari90 BhargavBhandari90 changed the title Issue #34: Allow to get users with no role WIP: Issue #34: Allow to get users with no role Aug 14, 2022
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for kicking this off, @BhargavBhandari90 !

Can you add some functional tests (Behat) for this pull request?

@BhargavBhandari90
Copy link
Contributor Author

Thanks for kicking this off, @BhargavBhandari90 !

Can you add some functional tests (Behat) for this pull request?

Sure, I'll add the behat test

@BhargavBhandari90 BhargavBhandari90 changed the title WIP: Issue #34: Allow to get users with no role Issue #34: Allow to get users with no role Aug 19, 2022
@danielbachhuber danielbachhuber changed the title Issue #34: Allow to get users with no role Support filtering for users without a role with --role=none Aug 22, 2022
@danielbachhuber danielbachhuber added the command:user-list Related to 'user list' command label Aug 22, 2022
@danielbachhuber danielbachhuber added this to the 2.2.3 milestone Aug 22, 2022
@danielbachhuber danielbachhuber self-requested a review August 22, 2022 20:03
@danielbachhuber danielbachhuber merged commit 66bdeae into wp-cli:master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:user-list Related to 'user list' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow filtering user list by users with no role

5 participants