Skip to content

Implement CS checking based on the WP_CLI_CS ruleset #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schlessera merged 29 commits into from
Apr 23, 2019
Merged

Implement CS checking based on the WP_CLI_CS ruleset #251

schlessera merged 29 commits into from
Apr 23, 2019

Conversation

@thrijith
Copy link
Member

@thrijith thrijith commented Apr 22, 2019

Add a PHPCS ruleset using the new WP_CLI_CS standard.

Fixes #248

Related wp-cli/wp-cli#5179

thrijith added 13 commits April 22, 2019 12:21
@thrijith
PHPCS: Add new ruleset to the project
59c5b8f 
Update .distignore and .gitignore with phpcs/phpunit config files
Update wp-cli-tests to 2.1
@thrijith
PHPCS: Fix up errors in src/WP_CLI/Entity
3dcdde1
@thrijith
PHPCS: Update ruleset to exclude calsses from NamingConventions sniff
c263125 
Fix CS in src/WP_CLI/Fetchers
@thrijith
PHPCS: Update ruleset to exclude classes from MethodDeclaration.Under…
c528826 
…score sniff

Fix CS in src/WP_CLI
@thrijith
PHPCS: Update ruleset to exclude classes from PrefixAllGlobals.NonPre…
1f09a46 
…fixedClassFound sniff

Fix CS in User commands
@thrijith
PHPCS: Update ruleset to exclude classes from PrefixAllGlobals.NonPre…
8595f9f 
…fixedClassFound sniff

Fix CS in Term command
@thrijith
PHPCS: Update ruleset to exclude classes from PrefixAllGlobals.NonPre…
d90e4e3 
…fixedClassFound sniff

Fix CS in Site command
@thrijith
PHPCS: Update ruleset to exclude classes from PrefixAllGlobals.NonPre…
a877b0f 
…fixedClassFound sniff

Fix CS in Post command
@thrijith
PHPCS: Update ruleset to exclude classes from PrefixAllGlobals.NonPre…
f4d37e9 
…fixedClassFound sniff

Fix CS in Option command
@thrijith
PHPCS: Update ruleset to exclude classes from PrefixAllGlobals.NonPre…
47de5f2 
…fixedClassFound sniff
@thrijith
PHPCS: Update ruleset to exclude classes from PrefixAllGlobals.NonPre…
9150098 
…fixedClassFound sniff

Fix CS in Menu command
@thrijith
PHPCS: Update ruleset to exclude classes from PrefixAllGlobals.NonPre…
9676531 
…fixedClassFound sniff

Fix CS in Comment command
@thrijith
PHPCS: Update ruleset to exclude classes from PrefixAllGlobals.NonPre…
7087a84 
…fixedClassFound sniff

Fix CS in Taxonomy command
thrijith
thrijith commented Apr 22, 2019
View reviewed changes
@schlessera
Copy link
Member

schlessera commented Apr 23, 2019

I whitelisted the remaining issue and added further CQ improvements.

@schlessera schlessera marked this pull request as ready for review April 23, 2019 09:07
@schlessera schlessera requested a review from a team as a code owner April 23, 2019 09:07
@schlessera schlessera added the scope:testing Related to testing label Apr 23, 2019
@schlessera schlessera added this to the 2.0.3 milestone Apr 23, 2019
@schlessera schlessera merged commit 95f2a07 into master Apr 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/use-phpcs branch April 23, 2019 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schlessera schlessera schlessera approved these changes

Assignees

No one assigned

Labels

scope:testing Related to testing

Projects

None yet

Milestone

2.0.3

Development

Successfully merging this pull request may close these issues.

Adopt and enforce new WP_CLI_CS standard

3 participants

@thrijith @schlessera