Add a new command for resetting a user password#119
Merged
schlessera merged 5 commits intomasterfrom Dec 22, 2017
Merged
Conversation
swissspidy
reviewed
Dec 21, 2017
src/User_Command.php
Outdated
| if ( $skip_email ) { | ||
| remove_filter( 'send_password_change_email', '__return_false' ); | ||
| } | ||
| WP_CLI::success( 'Passwords reset.' ); |
Member
There was a problem hiding this comment.
I don't know how other commands handle this, but can we change the success message a bit? Like this:
if ( 1 === count( $users ) ) {
WP_CLI::success( 'Password reset.' );
} else {
WP_CLI::success( 'Passwords reset.' );
}
Member
Author
There was a problem hiding this comment.
I don't know how other commands handle this, but can we change the success message a bit?
Good catch. The other commands pluralize based on the number of entities affected.
Updated in 7a575ba
schlessera
approved these changes
Dec 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.