Adds an optional --filename-format=<filename-format> argument#74
Adds an optional --filename-format=<filename-format> argument#74danielbachhuber merged 3 commits intowp-cli:mainfrom i-am-chitti:filename-format-arg
--filename-format=<filename-format> argument#74Conversation
|
We might want to rename this to The tests look good at first glance, I just don't understand why they are not running here on GitHub Actions 🤔 |
|
@swissspidy, In this repo, hypen ( IMO, we should follow the WP_CLI convention that is the underscore. This will require us to update the existing args name. Let me know if we need this update for the single Regarding the tests, the tests workflow under |
|
Hmm good point with the other args. Let's leave it as is then.
It's configured to run on schedule and on push and for all pull requests. So that's 3 separate triggers. See #68 for an example of an older PR where all the tests ran. @danielbachhuber do you perhaps have an idea why the tests might not be running here? 🤔 |
@swissspidy I think the push event is disabled when the scheduled event is disabled. I updated the README and all of the builds were triggered. |
|
Thanks for the PR, @i-am-chitti ! |
filename-format assoc arg--filename-format=<filename-format> argument
Fixes: #72
This PR addresses the following -
filename-formatassoc arg to customize the name of the archive file name{name}.{version}. Examples -{name}-{version},{name}-myOrg.{version}-distScreenshots