Tests for 47. Allow for leading slashes in .distignore #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working for zip Not quite working for tar The tar command is correct and works when I run it on the command line, but the tests are failing to exclude the file properly.
Member
Author
|
Tests are now passing on MacOS but not on GitHub Actions. The problem was that PHP's I've added a function to permit exceptions in I'll have to set up Ubuntu locally and run the tests there. I'll use nektos/act. |
schlessera
approved these changes
Jun 30, 2022
Working for zip Not quite working for tar The tar command is correct and works when I run it on the command line, but the tests are failing to exclude the file properly.
a23834b to
a1f922b
Compare
1. It seems `sys_get_temp_dir()` was being shared across multiple tests, so files already existed when subsequent tests were run. 2. Looks like the "no distignore file is present" test was failing after wp-cli#56 was merged.
…m/BrianHenryIE/dist-archive-command into anchor-distignore-entries-to-root
Member
Author
|
It seems There's a new test failure now! I have a feeling #59 will solve it. I'll work on the PR now. |
Member
|
Ship #61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example project:
with example
.distignore:Should archive:
This is working for
zip.The tests are failing for
tar, but when I echo the tar command that is being used and manually cd to the directory and paste and run it, it works.Could someone please take a look and see if they can make sense of why it's not working? I'm guessing it's related to the current working directory being somehow affected inside
WP_CLI::launch().@markjaquith