Skip to content

Cleanup for --skip-content flag#40

Merged
schlessera merged 5 commits intomasterfrom
36-cleanup
Oct 2, 2017
Merged

Cleanup for --skip-content flag#40
schlessera merged 5 commits intomasterfrom
36-cleanup

Conversation

@danielbachhuber
Copy link
Member

@danielbachhuber danielbachhuber commented Oct 1, 2017

  • Cleanup tests for greater specificity.
  • Move errors to an earlier position to prevent unnecessary code execution.
  • Use the appropriate cache key name for --skip-content.
  • Avoid duplicate API requests by executing code path earlier.

Fixes #36

@danielbachhuber danielbachhuber added this to the 1.0.3 milestone Oct 1, 2017
@danielbachhuber danielbachhuber added the command:core-download Related to 'core download' command label Oct 1, 2017
@danielbachhuber danielbachhuber requested a review from a team October 1, 2017 13:51
@danielbachhuber
Copy link
Member Author

danielbachhuber commented Oct 1, 2017

@AaronRutley ^ Worth looking through those changes to see the cleanup I did.

@AaronRutley
Copy link

AaronRutley commented Oct 2, 2017

@danielbachhuber! I've just had a look over your cleanup commits, it all makes sense, thanks!

@schlessera schlessera merged commit e3ae26e into master Oct 2, 2017
@schlessera schlessera deleted the 36-cleanup branch October 2, 2017 11:37
@danielbachhuber danielbachhuber added the command:core Related to 'core' command label Dec 8, 2017
@danielbachhuber danielbachhuber mentioned this pull request Dec 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schlessera schlessera schlessera approved these changes

Assignees

No one assigned

Labels

command:core Related to 'core' command command:core-download Related to 'core download' command

Projects

None yet

Milestone

1.0.3

Development

Successfully merging this pull request may close these issues.

3 participants

@danielbachhuber @AaronRutley @schlessera