Use `--skip-content` to download WordPress without default themes/plugins (US locale only) by AaronRutley · Pull Request #37 · wp-cli/core-command

AaronRutley · 2017-09-27T10:25:32Z

Allow users to install WordPress without content eg: wp core download --skip-content
See these issues for context #36 & wp-cli/ideas#59

This is my first pass, please let me know what needs improvement.

ocean90 · 2017-09-27T11:14:55Z

src/Core_Command.php

 		}

+		if ( true === \WP_CLI\Utils\get_flag_value( $assoc_args, 'skip-content' ) ) {
+			$offer = unserialize( self::_read( 'https://api.wordpress.org/core/version-check/1.6/' ) );


Any reason for not using https://api.wordpress.org/core/version-check/1.7/ which provides JSON data?

Hey @ocean90, I opted for /1.6/ as it's used is for this command here

I'm happy to swap it for /1.7/ if needed!

Gotcha, maybe there's a reason... cc @danielbachhuber

Here's the original commit: wp-cli/wp-cli@3fbef8b

My assumption is that 1.7 wasn't available.

Thanks @danielbachhuber,
Would you like to continue using 1.6 or should we change to 1.7?

ocean90 · 2017-09-27T11:15:50Z

src/Core_Command.php

+			$offer = unserialize( self::_read( 'https://api.wordpress.org/core/version-check/1.6/' ) );
+			$download_url = $offer['offers'][0]["packages"]["no_content"];
+			$version = $offer['offers'][0]["current"].' without content';
+		}


Since there's a Nightly builds are only available for the en_US locale. error, packages with no content are also only available for the en_US locale.

Thanks @ocean90, I've just added this AaronRutley@dd9a40c

…locale

danielbachhuber · 2017-09-27T13:11:09Z

features/core-download.feature

+    When I run `wp core download --skip-content`
+    And save STDOUT 'Downloading WordPress ([\d\.]+)' as {VERSION}
+    Then the wp-settings.php file should exist
+    And the {SUITE_CACHE_DIR}/core/wordpress-{WP_VERSION-latest}-without-content-en_US.zip file should exist


Can you create a new Scenario for this behavior please (instead of repurposing an existing one)?

We'll also need to make sure there are tests for:

Non US locales

Use of --version=<version>

Thanks @danielbachhuber, I've just created 3 new scenarios.

danielbachhuber · 2017-09-27T13:15:58Z

src/Core_Command.php

+
+		if ( true === \WP_CLI\Utils\get_flag_value( $assoc_args, 'skip-content' ) && 'en_US' !== $locale ) {
+			WP_CLI::error( 'The skip content build is only available for the en_US locale.' );
+		}


I think it would make sense to render this error earlier on, to avoid an unnecessary HTTP request when the error will render.

Also, did you confirm this is the case? That --skip-content is available for the en_US locale?

Thanks @danielbachhuber, I've moved this check to earlier on.
Yes, as I understand, --skip-content is only available for the en_US locale.

danielbachhuber · 2017-09-28T12:16:19Z

features/core-download.feature

+    Given an empty directory
+    And an empty cache
+
+    When I run `wp core download --skip-content --locale=nl_NL`


This should be When I try, because the expected result is an error.

Thanks, I've just fixed.

danielbachhuber · 2017-09-28T12:16:35Z

features/core-download.feature

+    And an empty cache
+
+    When I run `wp core download --skip-content --locale=nl_NL`
+    Then STDOUT should contain:


This should be Then STDERR should contain

Thanks, I've just fixed.

danielbachhuber · 2017-09-28T12:16:45Z

features/core-download.feature

+    Given an empty directory
+    And an empty cache
+
+    When I run `wp core download --skip-content --version=4.7`


Ditto above

Thanks, I've just fixed.

danielbachhuber · 2017-09-28T12:16:51Z

features/core-download.feature

+    And an empty cache
+
+    When I run `wp core download --skip-content --version=4.7`
+    Then STDOUT should contain:


Ditto above

Thanks, I've just fixed.

danielbachhuber · 2017-09-28T12:17:53Z

src/Core_Command.php

 	 * : Overwrites existing files, if present.
 	 *
+	 * [--skip-content]
+	 * : Download the latest version of WP without the default themes and plugins


Can we include some mention that this only works when locale is en_US?

For sure, I've just updated.

danielbachhuber · 2017-09-28T12:19:03Z

src/Core_Command.php

+
+		if ( true === \WP_CLI\Utils\get_flag_value( $assoc_args, 'skip-content' ) ) {
+			$offer = unserialize( self::_read( 'https://api.wordpress.org/core/version-check/1.6/' ) );
+			$download_url = $offer['offers'][0]["packages"]["no_content"];


We need to check that $offer['offers'][0]["packages"]["no_content"]; is set, and error if it's not.

Thanks for your feedback, I've just addressed this!

danielbachhuber · 2017-09-28T12:19:22Z

src/Core_Command.php

+		}
+
+		if ( true === \WP_CLI\Utils\get_flag_value( $assoc_args, 'skip-content' ) ) {
+			$offer = unserialize( self::_read( 'https://api.wordpress.org/core/version-check/1.6/' ) );


Let's switch this to the v1.7 API

Thanks for your feedback, I've just addressed this!

danielbachhuber · 2017-10-01T13:35:57Z

Thanks for your work on this @AaronRutley !

Aaron Rutley added 3 commits September 27, 2017 20:00

add feature to allow users to skip content

cd1e6e4

add test for the skip content flag

8ff6ab9

fix typo in test for skip content flag

650fad2

ocean90 reviewed Sep 27, 2017

View reviewed changes

add error message to ensure skip content is only used with the en_US …

dd9a40c

…locale

danielbachhuber requested changes Sep 27, 2017

View reviewed changes

Aaron Rutley added 3 commits September 28, 2017 20:25

check for locale earlier to avoid an unnecessary HTTP request

ab1a150

add two new scenario's to test the skip-content flag

3efd28c

show error if a version is set when the skip-content flag is also set

b1f5e1b

danielbachhuber requested changes Sep 28, 2017

View reviewed changes

Aaron Rutley added 7 commits September 29, 2017 10:58

update skip content call to use 1.7 API

b320e22

fix the tests for skip-content flag

428913d

improve error handeling

e5d62d2

help updated for skip-content

20f29b5

remove check of cache version from tests for now

5924448

update error message to pass tests

051b918

update error messages and tests

abf748a

danielbachhuber added this to the 1.0.3 milestone Oct 1, 2017

danielbachhuber added command:core command:core-download Related to 'core download' command labels Oct 1, 2017

danielbachhuber approved these changes Oct 1, 2017

View reviewed changes

danielbachhuber merged commit aa301bd into wp-cli:master Oct 1, 2017

danielbachhuber changed the title ~~Add skip content flag feature~~ Use --skip-content to download WordPress without default themes/plugins (US locale only) Oct 2, 2017

danielbachhuber mentioned this pull request Oct 15, 2017

Use WP_CLI\Utils\http_request() to fetch skip-content build #41

Merged

danielbachhuber added the command:core Related to 'core' command label Dec 8, 2017

danielbachhuber mentioned this pull request Dec 8, 2017

Make --skip-content flag available to more versions and locales #57

Closed

danielbachhuber mentioned this pull request Mar 9, 2023

The --skip-content flag does not create folders inside wp-content #228

Closed

danielbachhuber mentioned this pull request Apr 24, 2023

Leave wp-content/plugins and wp-content/themes directories when using --skip-content #230

Merged

Conversation

AaronRutley commented Sep 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AaronRutley Sep 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danielbachhuber commented Oct 1, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AaronRutley commented Sep 27, 2017 •

edited

Loading

AaronRutley Sep 27, 2017 •

edited

Loading