Check more files to determine if WordPress is present or not#233
Merged
danielbachhuber merged 2 commits intowp-cli:mainfrom May 24, 2023
Merged
Check more files to determine if WordPress is present or not#233danielbachhuber merged 2 commits intowp-cli:mainfrom
danielbachhuber merged 2 commits intowp-cli:mainfrom
Conversation
Added the user confirmation prompt while re-downloading the WordPress core files when user have alerady downloaded. Also added the modified version to check multiple WordPress files so that it does not have dependency on `wp-load.php` file.
2 tasks
danielbachhuber
approved these changes
May 24, 2023
Member
Makes sense, this seems fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description
wp core download, it would throw an error sayingWordPress files seem to already be present here.This is only dependent point for this command to identify the WordPress files are present or not.Solution
Test
core-command/features/core.feature
Lines 293 to 302 in e3212a3
Cc: @danielbachhuber