Add a --skip-config flag to wp core multisite-convert#231
Merged
danielbachhuber merged 2 commits intowp-cli:mainfrom May 24, 2023
Merged
Add a --skip-config flag to wp core multisite-convert#231danielbachhuber merged 2 commits intowp-cli:mainfrom
--skip-config flag to wp core multisite-convert#231danielbachhuber merged 2 commits intowp-cli:mainfrom
Conversation
Provided the support to skip the configuration of wp-config file by passing the --skip-config associate param. This is already being added for multiiste install command.
Member
|
Thanks a lot for your PR! Convenient that this argument is automatically handled further down 😃 Could you perhaps also add a Behat test confirming that this works as expected? It could look like the existing test for core-command/features/core-install.feature Lines 277 to 287 in e3212a3 The new test can be added at the end of the |
Contributor
Author
|
Thanks, @swissspidy I Would add this soon. |
Contributor
Author
|
Hi @swissspidy, have added the behat test for the same. Can you please review and let me know if anything else needed? Thanks a lot for review. |
swissspidy
approved these changes
May 22, 2023
--skip-config flag to wp core multisite-convert
danielbachhuber
approved these changes
May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
--skip-configparameter so that user have an option to not add the config parameters towp-config.phpfile while using the commandwp core multisite-convert.Solution
--skip-configparameter to subcommand function doc block.--skip-config.multisite-installandmultisite-convertcommand have a common functionmultisite_convert_( $assoc_args )which have a check for this parameter and then proceed accordingly.Screenshot for command executed after the patch: