Support wp core download https://somesite/build.zip#135
Merged
schlessera merged 15 commits intowp-cli:masterfrom Oct 22, 2019
Merged
Support wp core download https://somesite/build.zip#135schlessera merged 15 commits intowp-cli:masterfrom
wp core download https://somesite/build.zip#135schlessera merged 15 commits intowp-cli:masterfrom
Conversation
Contributor
Author
|
#136 should fix the build. |
schlessera
requested changes
Oct 15, 2019
Member
schlessera
left a comment
There was a problem hiding this comment.
The code generally looks good, but I'd like to have the mechanism for providing the URL changed to not be hidden under the misleading --version=<version> flag.
Member
|
#136 was merged, so you can pull in the latest |
Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>
2c78c12 to
269a7dd
Compare
wp core download --version=https://somesite/build.zipwp core download https://somesite/build.zip
Contributor
Author
|
@schlessera thanks for the review, this is ready for another look. The Travis build has passed, but the PR hasn't updated accordingly. |
schlessera
requested changes
Oct 16, 2019
Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>
Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>
Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>
Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>
Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>
Member
|
Ah, just noticed that the I'll take this over the finish line from here. Thanks so much for the PR! |
schlessera
approved these changes
Oct 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #131.
This change also makes a failure to retrieve the MD5 checksum into a warning rather than an error, and fixes a related minor bug along the way:
Previously this printed
Couldn't access md5 hash for release (HTTP code 200)using the response code from the zip download.It'll be slightly easier to review this diff ignoring whitespace changes: https://github.com/wp-cli/core-command/pull/135/files?w=1