Skip to content

Tests in PHP 7.3 fail because of a misuse of compact() #113

@schlessera

Description

@schlessera

Tests are failing on PHP 7.3 because of https://www.php.net/manual/en/function.compact.php#refsect1-function.compact-changelog:

Screen Shot 2019-04-18 at 08 02 03

and https://github.com/WordPress/WordPress/blob/4.3.15/wp-includes/post.php#L3372 (couldn't find version 4.3.2 as used in the tests on GitHub:

$post_parent = apply_filters(
     'wp_insert_post_parent', 
    $post_parent, 
    $post_ID, 
    compact( array_keys( $postarr ) ), 
    $postarr 
);

Originally posted by @localheinz in #111 (comment)

Related wp-cli/wp-cli#5192

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions