Skip to content

PHPStan: Don't look in wp-cli-tests folder #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swissspidy merged 1 commit into from
Jun 11, 2025
Merged

PHPStan: Don't look in wp-cli-tests folder #200

swissspidy merged 1 commit into from
Jun 11, 2025

Conversation

@mrsdizzie
Copy link
Member

@mrsdizzie mrsdizzie commented Jun 11, 2025

This folder will also have a vendor folder and PHPStan will try and read every file in there, likely running out of memory eventually:

isla@Mac ~/source/wp-cli-dev/config-command (phpstan-config-fix|u=) $ composer phpstan
Note: Using configuration file /Users/isla/source/wp-cli-dev/config-command/phpstan.neon.dist.
PHP Fatal error:  Allowed memory size of 2147483648 bytes exhausted (tried to allocate 20480 bytes) in phar:///Users/isla/source/wp-cli-dev/vendor/phpstan/phpstan/phpst
an.phar/vendor/symfony/finder/SplFileInfo.php on line 29
Fatal error: Allowed memory size of 2147483648 bytes exhausted (tried to allocate 20480 bytes) in phar:///Users/isla/source/wp-cli-dev/vendor/phpstan/phpstan/phpstan.ph
ar/vendor/symfony/finder/SplFileInfo.php on line 29

PHPStan process crashed because it reached configured PHP memory limit: 2048M
Increase your memory limit in php.ini or run PHPStan with --memory-limit CLI option.
Script run-phpstan-tests handling the phpstan event returned with error code 255

@mrsdizzie
Don't look in wp-cli-tests folder
537ad24 
This folder will also have a vendor folder and PHPStan will try and read
every file in there, likely running out of memory eventually.
@mrsdizzie mrsdizzie requested a review from a team as a code owner June 11, 2025 19:11
@codecov
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@swissspidy swissspidy merged commit a482500 into main Jun 11, 2025
43 checks passed
@swissspidy swissspidy deleted the phpstan-config-fix branch June 11, 2025 19:32
@swissspidy swissspidy added this to the 2.4.0 milestone Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees

No one assigned

Labels

scope:testing

Projects

None yet

Milestone

2.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mrsdizzie @swissspidy