Verify a specific plugin version#108
Merged
danielbachhuber merged 10 commits intowp-cli:mainfrom May 23, 2023
reflexive-communications:verify-plugin-version
Merged
Verify a specific plugin version#108danielbachhuber merged 10 commits intowp-cli:mainfrom reflexive-communications:verify-plugin-version
danielbachhuber merged 10 commits intowp-cli:mainfrom
reflexive-communications:verify-plugin-version
Conversation
Contributor
Author
|
Functional tests are failing, and I don't know the reason. I've tried a few variations and I think the code is working as expected. Checking the output from "Run Behat" step:
I believe the same assertions are specified in the scenario (or at least that was my intention), and this is what should happen. @danielbachhuber do you have any idea? |
wojsmol
reviewed
May 22, 2023
Co-authored-by: Wojciech Smoliński <wojsmol@wp.pl>
Contributor
Author
|
OK, now tests are passing, it's ready for review! |
Member
danielbachhuber
left a comment
There was a problem hiding this comment.
Looks pretty good! Just a few nits to address, and then it should be ready to ship.
Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>
Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>
danielbachhuber
approved these changes
May 23, 2023
Member
danielbachhuber
left a comment
There was a problem hiding this comment.
Thanks for your work on this, @semseysandor !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #106