Log warning if WpOrgApi::get_plugin_checksums() fails#105
Merged
danielbachhuber merged 1 commit intowp-cli:mainfrom May 17, 2023
reflexive-communications:warning-get-plugin-checksum
Merged
Log warning if WpOrgApi::get_plugin_checksums() fails#105danielbachhuber merged 1 commit intowp-cli:mainfrom reflexive-communications:warning-get-plugin-checksum
WpOrgApi::get_plugin_checksums() fails#105danielbachhuber merged 1 commit intowp-cli:mainfrom
reflexive-communications:warning-get-plugin-checksum
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WpOrgApi::get_plugin_checksums()throws exception if failed to fetch checksums (e.g. network issues, wrong URL). In these cases at least a warning should be logged to add a hint about the error and save 90% of debug time.