refactored to breakout resourceId and resourceExternalId into separate itnerfaces that can be exported#1481
Merged
swaroopAkkineniWorkos merged 5 commits intoENT-4372-base-authorization-branchfrom Feb 12, 2026
Conversation
1ffafc4
into
ENT-4372-base-authorization-branch
8 checks passed
Contributor
Greptile OverviewGreptile SummaryThis PR refactors the authorization check interfaces to use discriminated union types, breaking out Key changes:
Note: The PR title contains a typo: "itnerfaces" should be "interfaces" Confidence Score: 3/5
Important Files Changed
|
Comment on lines
+11
to
14
| ...('resourceExternalId' in options && { | ||
| resource_external_id: options.resourceExternalId, | ||
| }), | ||
| ...(options.resourceTypeSlug && { | ||
| resource_type_slug: options.resourceTypeSlug, | ||
| }), |
Contributor
There was a problem hiding this comment.
The serialization logic will include both resource_id and resource_external_id/resource_type_slug if an object with all properties is passed at runtime. TypeScript types don't prevent { resourceId: 'x', resourceExternalId: 'y', resourceTypeSlug: 'z' } from being constructed and passed.
Consider using an else-if pattern to ensure mutual exclusivity:
Suggested change
| ...('resourceExternalId' in options && { | |
| resource_external_id: options.resourceExternalId, | |
| }), | |
| ...(options.resourceTypeSlug && { | |
| resource_type_slug: options.resourceTypeSlug, | |
| }), | |
| ...('resourceId' in options | |
| ? { resource_id: options.resourceId } | |
| : { | |
| resource_external_id: options.resourceExternalId, | |
| resource_type_slug: options.resourceTypeSlug, | |
| }), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.