Increase Minimum iOS Deployment to 9.0 for Xcode 12#52
Merged
Conversation
jkmassel
approved these changes
Sep 22, 2020
Contributor
jkmassel
left a comment
There was a problem hiding this comment.
This LGTM, I think it's safe to drop iOS 8 developers and below!
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! 👋 Please reject this PR if this is not the right way to approach this.
Problem
This library is a deep dependency of woocommerce-ios. Compiling WCiOS with Xcode 12 results in so many problems. One of which has already been fixed by @jkmassel in wordpress-mobile/WordPressKit-iOS#284. The rest are just warnings:
Solution
It looks like these warnings can be fixed by a workaround in
Podfile. But since we can also probably (?) fix it by upgrading the minimum iOS version in this library, I went with that for this one.The iOS minimum deployment target was changed to 9.0. Please let me know if it should be higher.
Changing the deployment target is enough to remove the build warning.
Testing