Skip to content
This repository was archived by the owner on Mar 7, 2025. It is now read-only.

Update unsupported block editor test cases#42

Merged
guarani merged 6 commits intomasterfrom
guarani/fix-unsupported-block-test-cases
Jul 9, 2020
Merged

Update unsupported block editor test cases#42
guarani merged 6 commits intomasterfrom
guarani/fix-unsupported-block-test-cases

Conversation

@guarani
Copy link
Copy Markdown
Contributor

@guarani guarani commented Jul 8, 2020

Removed new-line literals from Jetpack markdown sample HTML

@guarani guarani requested a review from marecar3 July 8, 2020 21:09
@guarani guarani changed the title Fixed broken jetpack markdown example Update unsupported block editor test cases Jul 9, 2020
Paul Von Schrottky added 2 commits July 8, 2020 22:11
Clarified wording around Jetpack connected self-hosted sites
Copy link
Copy Markdown
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor comments/questions, but looks good. Thanks @guarani ! 👍

@guarani guarani merged commit 201162d into master Jul 9, 2020
@hypest hypest deleted the guarani/fix-unsupported-block-test-cases branch July 10, 2020 07:22
- The Unsupported Block Editor is currently [not available on Jetpack connected self-hosted sites](https://github.com/wordpress-mobile/gutenberg-mobile/issues/2471)

### Self-hosted sites are supported
### Self-hosted sites are supported (if they are not connected to WordPress via Jetpack)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @guarani , when logging in the Jetpack .org site using username and password, does it matter if Jetpack is connected or not? The testcase makes it look like "not connected" is supported, but unsure about when connected.

Can we add a new testcase to cover the connected case, or rephrase that bit in the current testcase (say, by removing the mention to connected or not)?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. Now we've disabled self-hosted sites I'm going to go ahead and remove the test case entirely. (I think self-hosted sites were supported when the user used their username/password to log in.)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think self-hosted sites were supported when the user used their username/password to log in.

They were (before we found the issue with Classic editor popping up if Gutenberg is disabled) but I might be misunderstanding the testcase: when logging in with username/password the feature should actually have worked regardless of the Jetpack state (uninstalled, installed but not-connected, connected), right? 🤔

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants