This repository was archived by the owner on Mar 21, 2022. It is now read-only.
Maven repo is in node_modules when building as an npm dep#8
Merged
hypest merged 1 commit intofeature/enable-android-build-of-standalone-packagefrom Dec 20, 2019
Conversation
Merged
2 tasks
mchowning
approved these changes
Dec 20, 2019
mchowning
left a comment
There was a problem hiding this comment.
This is working for me. 👍
I think we may be better off using resoulutionStrategy within gradle, but I don't have that ready-to-go yet, so in order to unblock the team I'm fine merging this and if I get a better solution working I can put up another PR proposing to revert this and use the other solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When built as a normal npm package, the RN dep should be pulled from the node_modules.
This fixes the cases where a new, incompatible version of RN is otherwise picked up from the maven mirror.