Skip to content
This repository was archived by the owner on Mar 21, 2022. It is now read-only.

Fix compatibility with 0.60.0 CocoaPods patch#4

Merged
jtreanor merged 1 commit intofeature/enable-android-build-of-standalone-packagefrom
fix/0.60.0-patch
Jul 4, 2019
Merged

Fix compatibility with 0.60.0 CocoaPods patch#4
jtreanor merged 1 commit intofeature/enable-android-build-of-standalone-packagefrom
fix/0.60.0-patch

Conversation

@jtreanor
Copy link
Copy Markdown

@jtreanor jtreanor commented Jul 3, 2019

This makes two changes to be compatible with RN 0.60.0 plus the CocoaPods framework changes:

  • Depend only on React-Core and React-RCTImage instead of all of React.
  • Make imports work with both pre and post the CocoaPods frameworks changes.

@jtreanor jtreanor force-pushed the fix/0.60.0-patch branch from d09af3b to ba48541 Compare July 3, 2019 14:13
Copy link
Copy Markdown

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Tested via wordpress-mobile/WordPress-iOS#12056

@jtreanor jtreanor merged commit 466a40e into feature/enable-android-build-of-standalone-package Jul 4, 2019
@jtreanor jtreanor deleted the fix/0.60.0-patch branch July 4, 2019 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants