This repository was archived by the owner on Mar 7, 2025. It is now read-only.
Conversation
…re-mansion#3162) ## Description ReactApplicationContext.getCurentContext sometimes return null. This causes a crash (NullPointerException) in reanimated due to not checking if context exists. As per react native's examples, we can only measure device metrics when current activity is not null (https://github.com/facebook/react-native/blob/8bd3edec88148d0ab1f225d2119435681fbbba33/ReactCommon/react/nativemodule/samples/platform/android/SampleTurboModule.java#L56) Fixes software-mansion#2959. ## Changes Check if current activity is not null before measuring the device.
geriux
approved these changes
May 4, 2022
geriux
left a comment
There was a problem hiding this comment.
LGTM! I tested this using a Redmi Note 8T and the crash issue is no longer present 🎉 thanks for bringing those changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to address wordpress-mobile/gutenberg-mobile#4801, this PR incorporates the fix from this upstream commit into the
wp-forkbranch.How to test:
rnmobile/fix/drag-and-drop-android-crash-when-closing-editorin the Gutenberg repository.