This repository was archived by the owner on Jul 27, 2023. It is now read-only.
Upgrade compile and target sdk version to Android API 33#8
Merged
Conversation
fluiddot
commented
May 18, 2023
Author
There was a problem hiding this comment.
For some reason, this file got updated when installing the dependencies via yarn command. I switched to the wp-fork branch and I'm getting the same result, so I'm wondering if we overlook doing this when we created the fork 🤔.
There was a problem hiding this comment.
Interesting, let's include the change as it shouldn't affect anything.
c0cc65a to
5361929
Compare
geriux
approved these changes
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is related to the upgrade effort to Android 13 in Gutenberg Mobile: wordpress-mobile/gutenberg-mobile#5556. It basically updates all references of
compileSdkVersionandtargetSdkVersionparameters to use version33.This change is similar to when we upgrade to Android 12.
Test plan
This update can be tested using the Gutenberg editor and the following PR: WordPress/gutenberg#50731.
The idea would be to run smoke testing on the demo project in order to check that there are no issues with Android 13.