Skip to content

Add react-native-linear-gradient library with version 2.7.3 #30

Merged
fluiddot merged 1 commit intotrunkfrom
add-react-native-linear-gradient-2.7.3
Jun 28, 2023
Merged

Add react-native-linear-gradient library with version 2.7.3 #30
fluiddot merged 1 commit intotrunkfrom
add-react-native-linear-gradient-2.7.3

Conversation

@fluiddot
Copy link
Copy Markdown
Contributor

@fluiddot fluiddot commented Jun 27, 2023

Adds the latest version of the Linear gradient library.

This library is currently provided to Gutenberg Mobile via a forked repository. The only patch applied in the fork is related to moving the iOS files, which seems not needed compared to how the iOS files are structured in other forks (example). Hence, we could drop the fork in favor of the NPM package.

How to test

  1. Run the command npm install.
  2. Run the command ./gradlew react-native-linear-gradient:publishToMavenLocal -exclude-task prepareToPublishToS3
  3. Observe that the library is built and published successfully in the local folder ~/.m2/repository/org/wordpress-mobile/react-native-libraries.

Copy link
Copy Markdown

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I agree the logic for dropping the fork in favour of the NPM package seem sounds, and that the library appears correctly in my local folder following the testing steps:

Screenshot 2023-06-28 at 10 25 40

Thanks @fluiddot 🙌

@fluiddot fluiddot merged commit 333f98d into trunk Jun 28, 2023
@dcalhoun dcalhoun deleted the add-react-native-linear-gradient-2.7.3 branch June 28, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants