This repository was archived by the owner on Mar 7, 2025. It is now read-only.
Open a method to refresh the scroll due to caret#3
Merged
Conversation
We don't need any scrolling delay in case we trigger scroll programmatically.
We can trigger the scroll programmatically by directly calling refreshScrollForField
etoledom
approved these changes
Jan 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts a new method to refresh the scroll position for a specific component due to the caret position. This is to fix wordpress-mobile/gutenberg-mobile#464
To Test
Follow the steps on gutenberg-mobile PR