This repository was archived by the owner on Mar 7, 2025. It is now read-only.
Add prop extraBottomInset to fix the unwanted bottom inset#1
Merged
Conversation
This is added because we shouldn't always use extraScrollHeight to calculate the bottom inset of the content when keyboard is open. Some unwanted bottom inset occurs if we do.
etoledom
approved these changes
Dec 26, 2018
etoledom
left a comment
There was a problem hiding this comment.
Tested in the gutenberg-mobile project and is working great!
Full review here: wordpress-mobile/gutenberg-mobile#448
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is added because we shouldn't always use extraScrollHeight to calculate the bottom inset of the content when keyboard is open. Some unwanted bottom inset occurs if we do.
To Test
Follow the steps in the gutenberg-mobile PR.