This repository was archived by the owner on Jul 27, 2023. It is now read-only.
Conversation
7 tasks
ceyhun
approved these changes
Aug 31, 2021
ceyhun
left a comment
There was a problem hiding this comment.
Thanks Paul! Tested this by running npm install in the repo and the bob build step was successful.
Also the ./node_modules/.bin/tsc --version returned Version 4.1.2
be4ba53 to
5282a8f
Compare
A specific version avoids newer versions of TypeScript from being fetched in.
Author
|
Note: The latest commit on this branch, 0b284c3, has been tagged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The TypeScript dependency was not pinned to a specific version which allowed it to fetch changes that brought in breaking changes to downstream clients of this library.
Test plan