This repository was archived by the owner on Mar 7, 2025. It is now read-only.
Use NotoSerif by default or at least a bigger font#82
Merged
Conversation
|
Question regarding font scaling – does this work in tandem with device-level font size preferences? I'm curious how (if at all) this will scale up/down with device settings. |
Member
Author
|
Awesome, thanks for confirming! Text sizing within editors is a tricky thing, but it's good to know where we're at. |
etoledom
approved these changes
Nov 28, 2018
Contributor
etoledom
left a comment
There was a problem hiding this comment.
Works perfectly as advertised for both WordPress-iOS and the Gutenberg example app! ✅
Member
Author
|
Just noting that I haven't done the Android part since I'm not familiar with the font system there, but I think the default font size was already better than iOS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The existing default font was too tiny, I updated it to 16 points to match Aztec.
Also, if the NotoSerif font is available it will use that. I'm not super happy with the implementation, but making it configurable seemed like a lot of effort for now.
To test:
From WordPress-iOS, edit the
Podfileand point theRNTAztecViewpod to this branch:Run
bundle exec pod update RNTAztecViewRun the app, create or edit a post with Gutenberg and verify that the paragraph/heading blocks are using NotoSerif
If you run the gutenberg-mobile example app, it should show paragraphs with the system fonts but at 16 points.