Conversation
|
This looks fine and works as expected. Would you mind to check the default implementation of the same functionality in the bundled It seems that |
|
Thanks for pointing that out @daniloercoli ! I'm definitely going to play with that in subsequent PRs for sure 👍 Let me explain - I've been playing quite a bit with the I chose to use props That said, I'll play with that suggested implementation on other PRs to see if if helps fix other of the problems we may have (for example, wordpress-mobile/gutenberg-mobile#135). |
|
I agree with you to go step by step. I also think it's much easier that we initially though. Gutenberg and GB-mobile will still use the Anyway i'm going to mark this as good and merge it. |
This PR exposes
isSelectedas a property. Each time the property is updated with the valuetrue, we request the focus to be grabbed by the underlyingAztecTextview in Android.This comes in handy for programmatically setting the focus / blinking cursor on a given AztecText view: by setting the
isSelectedproperty totrue, an call torequestFocus()will be issued.