Skip to content

Move unselected block accessibility handling to block-holder#936

Closed
pinarol wants to merge 8 commits intodevelopfrom
issue/update-unselected-accessibility
Closed

Move unselected block accessibility handling to block-holder#936
pinarol wants to merge 8 commits intodevelopfrom
issue/update-unselected-accessibility

Conversation

@pinarol
Copy link
Copy Markdown
Contributor

@pinarol pinarol commented Apr 26, 2019

This PR moves accessibility handling of unselected blocks to block-holder, so:

  • We don't have to handle blocks separately. Every block will have at least their name(including unknown blocks) read by screen reader without extra coding.
  • If we want to provide more information for a block we'll need to inject its own getAccessibilityContent function as its attribute.
  • Some block content like Separator block have very little height, it is hard to select them otherwise.

gutenberg PR: WordPress/gutenberg#15214

Note: This is still a kind of experiment, we can decide not to merge this based on your opinions and tests.

To Test:

It should be enough to test in only 1 platform.
Check below items with Voice Over on:

  • Image block empty
  • Image block with image - selected
  • Image block with image - unselected
  • Next page
  • Paragraph block empty
  • Paragraph block with text
  • Post title empty
  • Post title with text
  • Unrecognized block
  • Separator block (Should tell its name)
  • Basic operations like Updating/Closing/Opening post

@pinarol
Copy link
Copy Markdown
Contributor Author

pinarol commented May 23, 2019

Closing this since we are handling it in #937

@pinarol pinarol closed this May 23, 2019
@Tug Tug deleted the issue/update-unselected-accessibility branch May 23, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant