Move unselected block accessibility handling to block-holder#936
Closed
Move unselected block accessibility handling to block-holder#936
Conversation
Closed
5 tasks
Contributor
Author
|
Closing this since we are handling it in #937 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves accessibility handling of unselected blocks to block-holder, so:
getAccessibilityContentfunction as itsattribute.gutenberg PR: WordPress/gutenberg#15214
Note: This is still a kind of experiment, we can decide not to merge this based on your opinions and tests.
To Test:
It should be enough to test in only 1 platform.
Check below items with Voice Over on: