Skip to content

Fix change list type crash#880

Merged
etoledom merged 3 commits intodevelopfrom
issue/fix-changeListType-not-function
Apr 17, 2019
Merged

Fix change list type crash#880
etoledom merged 3 commits intodevelopfrom
issue/fix-changeListType-not-function

Conversation

@etoledom
Copy link
Copy Markdown
Contributor

This PR updates the Gutenberg ref to test the Fix change list type crash PR.

Screen Shot 2019-04-17 at 10 22 34 AM

To test:

  • Run the app.
  • Add a ListBlock.
  • Change the list type to Ordered List.
  • Check that it doesn't crash.

@etoledom etoledom added this to the v1.3 milestone Apr 17, 2019
@etoledom etoledom requested a review from hypest April 17, 2019 08:33
@etoledom etoledom self-assigned this Apr 17, 2019
Copy link
Copy Markdown
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on the finding Eduardo, this looks good to me!

@etoledom etoledom merged commit 032cef5 into develop Apr 17, 2019
@etoledom
Copy link
Copy Markdown
Contributor Author

Thank you! 🙏

@etoledom etoledom deleted the issue/fix-changeListType-not-function branch April 17, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants