Skip to content

Check if onFocus is not undefined before calling it#866

Merged
marecar3 merged 2 commits intodevelopfrom
fix/865-on_focus_can_be_sometimes_unefined_on_iOS
Apr 12, 2019
Merged

Check if onFocus is not undefined before calling it#866
marecar3 merged 2 commits intodevelopfrom
fix/865-on_focus_can_be_sometimes_unefined_on_iOS

Conversation

@marecar3
Copy link
Copy Markdown
Contributor

@marecar3 marecar3 commented Apr 12, 2019

Fixes : #865

Corresponding gutenberg PR : WordPress/gutenberg#14967

@marecar3 marecar3 self-assigned this Apr 12, 2019
@marecar3 marecar3 added the [Type] Bug Something isn't working label Apr 12, 2019
@marecar3 marecar3 added this to the v1.3 milestone Apr 12, 2019
Copy link
Copy Markdown
Contributor

@JavonDavis JavonDavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS Release configurations are now working again locally and in CI... Thanks! LGTM 👍🏽

@marecar3 marecar3 changed the title onFocus is sometimes undefined when app is started from iOS device onFocus is sometimes undefined Apr 12, 2019
@marecar3 marecar3 changed the title onFocus is sometimes undefined Check if onFocus is not undefined before calling it Apr 12, 2019
@marecar3 marecar3 merged commit aa513ba into develop Apr 12, 2019
@marecar3 marecar3 deleted the fix/865-on_focus_can_be_sometimes_unefined_on_iOS branch April 12, 2019 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Post Title can't be re-focused after focus has changed

2 participants