Load the data package from local GB source tree#68
Merged
Conversation
Otherwise, `data` tries to pull in the `element` package from NPM and apparently this ends up messing with the locally loaded `element` package too. So, even though the `data` package doesn't contain mobile native code (and thus we could just pull it from NPM) we seem forced to load it from local too.
SergioEstevao
approved these changes
Jul 17, 2018
Contributor
SergioEstevao
left a comment
There was a problem hiding this comment.
This PR makes the project to bundle and build correctly again! 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67
With #66, the
@wordpress/datapackage is pulled from NPM while the@wordpress/elementfrom local GB source. Thing is,datatries to pull in theelementpackage as well and that gets resolved from NPM. Apparently this ends up messing up with the locally loadedelementpackage too. So, even though thedatapackage doesn't contain any mobile native code (and thus we could just pull it from NPM) we seem forced to load it from local too.This PR let's
@wordpress/databe resolved from the local GB source tree.To test
node_modulesfolderyarn installyarn start:resetyarn androidoryarn ios