test: Improve E2E test consistency#6313
Merged
dcalhoun merged 2 commits intoOct 24, 2023
Merged
Conversation
There may be clarity and efficiency by having an explicit setup script. It was avoid running unnecessary scripts during test runs. It is also referenced in the current documentation as a script to run intentionally.
aa22694 to
185c24c
Compare
geriux
approved these changes
Oct 24, 2023
geriux
left a comment
Contributor
There was a problem hiding this comment.
LGTM! The CI check that failed is related to a flaky test and not because of these changes 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid setup scripts during test runs to mirror changes in
WordPress/gutenberg#55554.
To test:
npm run core test:e2e:setupcommand succeeds when run.npm run test:e2e:ios:localcommand does not throw errors.npm run test:e2e:android:localcommand does not throw errors.PR submission checklist: