Skip to content

[RNMobile] Social Icons: Ensure inactive icons are visible with block-based themes #6302

Merged
SiobhyB merged 14 commits into
trunkfrom
version-toolkit/gutenberg/rnmobile/social-icon-background-dark-mode
Oct 25, 2023
Merged

[RNMobile] Social Icons: Ensure inactive icons are visible with block-based themes #6302
SiobhyB merged 14 commits into
trunkfrom
version-toolkit/gutenberg/rnmobile/social-icon-background-dark-mode

Conversation

@wpmobilebot

@wpmobilebot wpmobilebot commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator

Related PRs

Description

This PR is generated by version-toolkit to downstream the changes for gutenberg submodule.

@SiobhyB SiobhyB self-assigned this Oct 19, 2023
@SiobhyB SiobhyB mentioned this pull request Oct 19, 2023
Merged
@SiobhyB SiobhyB requested review from dcalhoun and geriux October 19, 2023 22:03
@geriux

geriux commented Oct 23, 2023

Copy link
Copy Markdown
Contributor

Hey @SiobhyB 👋 Since we are updating how the social icons get rendered, we'd need to update the visual tests snapshots before merging this PR.

@derekblank derekblank modified the milestone: 1.107.0 (23.6) Oct 24, 2023
@SiobhyB

SiobhyB commented Oct 24, 2023

Copy link
Copy Markdown
Contributor

@geriux, thank you! I'm currently experiencing some issues running the UI tests but will update here when I've updated the snapshots.

@geriux

geriux commented Oct 24, 2023

Copy link
Copy Markdown
Contributor

@geriux, thank you! I'm currently experiencing some issues running the UI tests but will update here when I've updated the snapshots.

No problem! Let me know if I can help with those issues!

@SiobhyB

SiobhyB commented Oct 25, 2023

Copy link
Copy Markdown
Contributor

@geriux, screenshots are updated now :)

@geriux

geriux commented Oct 25, 2023

Copy link
Copy Markdown
Contributor

@geriux, screenshots are updated now :)

Thank you!

It looks like this PR is not referencing the latest changes in Gutenberg trunk where we made changes for Appium 2. Since this PR is up to date with Gutenberg Mobile's trunk it'd be ideal to sync them so we can run the full tests before merging.

Maybe it'd be easier to merge WordPress/gutenberg#55398 and update the Gutenberg reference with the merge commit in this PR. What do you think?

@SiobhyB

SiobhyB commented Oct 25, 2023

Copy link
Copy Markdown
Contributor

Maybe it'd be easier to merge WordPress/gutenberg#55398 and update the Gutenberg reference with the merge commit in this PR. What do you think?

Yes, of course, I've gone ahead to begin the merge waterfall now.

geriux
geriux approved these changes Oct 25, 2023
View reviewed changes

@geriux geriux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tests passed correctly in CI 🚀 Nice work!

@SiobhyB SiobhyB merged commit e68263a into trunk Oct 25, 2023
@SiobhyB SiobhyB deleted the version-toolkit/gutenberg/rnmobile/social-icon-background-dark-mode branch October 25, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcalhoun dcalhoun Awaiting requested review from dcalhoun
1 more reviewer
@geriux geriux geriux approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@SiobhyB SiobhyB

Labels

Dark mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wpmobilebot @geriux @SiobhyB @derekblank