Skip to content

test: Update Gallery test for Appium 2#6293

Merged
dcalhoun merged 2 commits into
version-toolkit/gutenberg/rnmobile/appium-2from
test/appium-update-gallery
Oct 18, 2023
Merged

test: Update Gallery test for Appium 2#6293
dcalhoun merged 2 commits into
version-toolkit/gutenberg/rnmobile/appium-2from
test/appium-update-gallery

Conversation

@dcalhoun

@dcalhoun dcalhoun commented Oct 17, 2023

Copy link
Copy Markdown
Member

Related PRs

What?

Relates to #6276. Update the Gallery tests for Appium 2 and WebdriverIO.

Why?

Improve the stability and quality of the automated tests.

How?

  • Replace sleep with pause
  • Repair utility to close the bottom sheet

Testing Instructions

Local tests should pass for both platforms when running the following commands:

TEST_RN_PLATFORM=ios npm run device-tests:local gutenberg-editor-gallery-visual
TEST_RN_PLATFORM=android npm run device-tests:local gutenberg-editor-gallery-visual
  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

Update syntax for WebdriverIO, which is a part of the Appium 2 upgrade.
@dcalhoun dcalhoun added Testing Anything related to automated tests [Type] Task labels Oct 17, 2023
@dcalhoun dcalhoun self-assigned this Oct 17, 2023
@dcalhoun dcalhoun marked this pull request as ready for review October 17, 2023 20:07
@dcalhoun dcalhoun requested a review from geriux October 17, 2023 20:07
@dcalhoun dcalhoun mentioned this pull request Oct 17, 2023
7 tasks

@geriux geriux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tests run as expected locally and on SauceLabs 🚀 Nice work!

@dcalhoun dcalhoun merged commit 4c413fd into version-toolkit/gutenberg/rnmobile/appium-2 Oct 18, 2023
@dcalhoun dcalhoun deleted the test/appium-update-gallery branch October 18, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing Anything related to automated tests [Type] Task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants