Update Functionality Test 4 for Appium 2#6291
Merged
geriux merged 4 commits intoOct 19, 2023
Merged
Conversation
This was referenced Oct 17, 2023
dcalhoun
approved these changes
Oct 17, 2023
dcalhoun
left a comment
Member
There was a problem hiding this comment.
Verified the test plan succeeded. 🚀
Member
There was a problem hiding this comment.
It appears the button elements shifted slightly here and in the dark mode snapshot. Do you know why that is the case?
Contributor
Author
There was a problem hiding this comment.
It looks like before the migration we were adding a space at the beginning of the text, if you see the previous screenshot, the text is not aligned. We've changed quite a few utils so it seems we had a bug somewhere 🤔
added 4 commits
October 19, 2023 12:07
…of the whole block, it also adds a custom padding
739dff5 to
64880c3
Compare
Contributor
Author
|
I'm going to merge this PR since the test failure is not related to this change. I'll create a different PR to fix that flaky test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs
What?
This PR updates the Functionality Test 4 tests to WebdriverIO and Appium 2.
Why?
To continue with the migration effort to support this new version and new driver.
How?
sleepin favor ofpausetakeScreenshotByElementTesting Instructions
Local tests should pass by running the following command for both platforms:
Android
iOS
I've also confirmed it runs on SauceLabs by triggering the test from a local command against the Appium 2 build.
PR submission checklist: