Skip to content

Update Functionality Test 1 for Appium 2#6290

Merged
geriux merged 5 commits into
version-toolkit/gutenberg/rnmobile/appium-2from
test/functionality-test-1-migration
Oct 18, 2023
Merged

Update Functionality Test 1 for Appium 2#6290
geriux merged 5 commits into
version-toolkit/gutenberg/rnmobile/appium-2from
test/functionality-test-1-migration

Conversation

@geriux

@geriux geriux commented Oct 17, 2023 •
edited by dcalhoun
Loading

Copy link
Copy Markdown
Contributor

Related PRs

What?

This PR updates the Functionality Test 1 tests to WebdriverIO and Appium 2.

Why?

To continue with the migration effort to support this new version and new driver.

How?

  • Renaming the element selectors
  • Replace the usage of sleep in favor of pause
  • Migrated the usage of execute
  • Added an extra pause before capturing the screenshot due to flakiness related to the scrollbar appearing in the screenshot where it shouldn't

Testing Instructions

Local tests should pass by running the following command for both platforms:

Android

TEST_RN_PLATFORM=android npm run device-tests:local gutenberg-editor-functionality-test-1-visual.test

iOS

TEST_RN_PLATFORM=ios npm run device-tests:local gutenberg-editor-functionality-test-1-visual.test

I've also confirmed it runs on SauceLabs by triggering the test from a local command against the Appium 2 build.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added the Testing Anything related to automated tests label Oct 17, 2023
@geriux geriux requested a review from dcalhoun October 17, 2023 11:58
@geriux geriux mentioned this pull request Oct 17, 2023
Merged
7 tasks
dcalhoun
dcalhoun approved these changes Oct 17, 2023
View reviewed changes
Comment thread __device-tests__/gutenberg-editor-functionality-test-1-visual.test.js Outdated
@dcalhoun

dcalhoun commented Oct 17, 2023

Copy link
Copy Markdown
Member

Friendly note: I updated the Testing Instructions to remove the native command, as that caused the commands to fail within the context of gutenberg-mobile.

@geriux geriux merged commit 3ef4e1e into version-toolkit/gutenberg/rnmobile/appium-2 Oct 18, 2023
@geriux geriux deleted the test/functionality-test-1-migration branch October 18, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

Assignees

No one assigned

Labels

Testing Anything related to automated tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@geriux @dcalhoun