test: Update Unsupported Block tests for Appium 2#6281
Merged
dcalhoun merged 11 commits intoOct 16, 2023
Merged
Conversation
This was referenced Oct 12, 2023
Update syntax for WebdriverIO, which is a part of the Appium 2 upgrade.
WebdriverIO (the replacement for the deprecated WD driver library) does not have a method for retrieving a device's pixel ratio. Therefore, this sets an explicit value for each of our test devices.
There appears to be a small delay before the selection border displays.
It is unclear why this image needs updating. Its sibling iOS image was updated in: 4346add
f5fa9ff to
b2f9ce4
Compare
dcalhoun
commented
Oct 13, 2023
Mirror Android implementation found in Appium 2.
This reverts commit 079b7d6.
geriux
approved these changes
Oct 16, 2023
geriux
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Tests succeeded as expected 🚀
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs
What?
Relates to #6276. Update the Unsupported Block tests for Appium 2 and
WebdriverIO.
Why?
Improve the stability and quality of the automated tests.
How?
WebdriverIO (the replacement for the deprecated WD driver library) does
not have a method for retrieving a device's pixel ratio. Therefore, this
sets an explicit value for each of our test devices.
sleepwithpauseutilityTesting Instructions
Local tests should pass for both platforms when running the following commands:
PR submission checklist: