Skip to content

Expand analytics for block insertion/replacement#5976

Merged
geriux merged 11 commits intotrunkfrom
expand-analytics-for-block-insertion
Jul 20, 2023
Merged

Expand analytics for block insertion/replacement#5976
geriux merged 11 commits intotrunkfrom
expand-analytics-for-block-insertion

Conversation

@geriux
Copy link
Copy Markdown
Contributor

@geriux geriux commented Jul 18, 2023 •
edited
Loading

Related PRs:

This PR improves the analytics we have related to block insertion, it brings some code from Calypso to take into account block replacement and getting the source of where a block was inserted or replaced.

To test:

Precondition:

  • Run the editor using the host apps with metro running.

Inserter

  • Add blocks using the Inserter
  • Check the logs (Xcode/Logcat)
  • Expect to see the event editor_block_inserted with the insert_method property with header-inserter

Quick inserter

  • Add blocks using the quick Inserter (Available when the title is selected or when no block is selected) and the quick blocks buttons in the Header Toolbar.
  • Check the logs (Xcode/Logcat)
  • Expect to see event editor_block_inserted with the insert_method property with quick-inserter

Slash inserter

  • Add blocks using slash inserter.
  • Check the logs (Xcode/Logcat)
  • Expect to see event editor_block_inserted with the insert_method property with slash-inserter

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux self-assigned this Jul 18, 2023
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jul 18, 2023 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@geriux geriux mentioned this pull request Jul 18, 2023
Merged
@geriux geriux marked this pull request as ready for review July 18, 2023 16:34
@geriux geriux requested a review from fluiddot July 18, 2023 16:35
@geriux
Copy link
Copy Markdown
Contributor Author

geriux commented Jul 18, 2023

Hey @fluiddot 👋 I have added you as a reviewer for this PR, let me know if you could take a look whenever you can. Thank you!

@fluiddot
Copy link
Copy Markdown
Contributor

fluiddot commented Jul 19, 2023

Hey @fluiddot 👋 I have added you as a reviewer for this PR, let me know if you could take a look whenever you can. Thank you!

Sure, I can take a look 👀 .

fluiddot
fluiddot reviewed Jul 19, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@fluiddot fluiddot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the events generated and confirmed it's adding the proper inserter source 🎊. However, I noticed that we are generating the editor_block_inserted event in more cases than before (reference).

fluiddot
fluiddot reviewed Jul 19, 2023
View reviewed changes
@geriux geriux requested a review from fluiddot July 19, 2023 14:18
fluiddot
fluiddot reviewed Jul 19, 2023
View reviewed changes
fluiddot
fluiddot reviewed Jul 19, 2023
View reviewed changes
@geriux geriux requested a review from fluiddot July 20, 2023 07:49
fluiddot
fluiddot approved these changes Jul 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@fluiddot fluiddot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 ! I've added some minor comments related to function documentation, but feel free to skip them.

@geriux geriux merged commit 3f24cc5 into trunk Jul 20, 2023
@geriux geriux deleted the expand-analytics-for-block-insertion branch July 20, 2023 12:17
@fluiddot fluiddot added this to the 1.100.0 (22.9) milestone Jul 21, 2023
@fluiddot fluiddot mentioned this pull request Jul 21, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fluiddot fluiddot fluiddot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@geriux geriux

Labels

Analytics Project: Editor UX Improvements

Projects

None yet

Milestone

1.100.0 (22.9)

Development

Successfully merging this pull request may close these issues.

2 participants

@geriux @fluiddot