Workaround React Native 0.71 and XCFramework setup issues#5912
Closed
mokagio wants to merge 29 commits intoupgrade/react-native-0.71-iosfrom
Closed
Workaround React Native 0.71 and XCFramework setup issues#5912mokagio wants to merge 29 commits intoupgrade/react-native-0.71-iosfrom
mokagio wants to merge 29 commits intoupgrade/react-native-0.71-iosfrom
Conversation
The issue is due to RNReanimated looking for react-native in the
node_modules relative to its location, which is how most projects would
be setup. Unfortunately, our projects is not standard.
When running `pod install` or `pod update`, we'd get:
```
Installing RNReanimated 2.17.0 (was 2.9.1-wp-4)
internal/modules/cjs/loader.js:934
throw err;
^
Error: Cannot find module 'react-native/package.json'
Require stack:
- /Users/gio/Developer/a8c/gutenberg-mobile/ios-xcframework/[eval]
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:931:15)
at Function.resolve (internal/modules/cjs/helpers.js:113:19)
at [eval]:1:9
at Script.runInThisContext (vm.js:134:12)
at Object.runInThisContext (vm.js:310:38)
at internal/process/execution.js:81:19
at [eval]-wrapper:6:22
at evalScript (internal/process/execution.js:80:60)
at internal/main/eval_string.js:27:3 {
code: 'MODULE_NOT_FOUND',
requireStack: [
'/Users/gio/Developer/a8c/gutenberg-mobile/ios-xcframework/[eval]'
]
}
[!] Invalid `RNReanimated.podspec` file: no implicit conversion of nil into String.
# from /var/folders/dq/cdqxvx3s5ps75564rpmb_dc00000gn/T/d20230627-89428-abwplk/RNReanimated.podspec:5
# -------------------------------------------
# reanimated_package_json = JSON.parse(File.read(File.join(__dir__, "package.json")))
> config = find_config()
# assert_no_multiple_instances(config)
# -------------------------------------------
```
b77ceee to
f1fde4c
Compare
4 tasks
Using only our custom specs, the build failed with ``` Multiple commands produce '/Users/gio/Developer/a8c/gutenberg-mobile/ios-xcframework/DerivedData/XCFrameworkScaffold/Build/Products/Debug-iphonesimulator/ReactCommon/ReactCommon.framework/Headers/CallbackWrapper.h' - Target 'ReactCommon' (project 'Pods') has copy command from '/Users/gio/Developer/a8c/gutenberg-mobile/ios-xcframework/Pods/ReactCommon/react/bridging/CallbackWrapper.h' to '/Users/gio/Developer/a8c/gutenberg-mobile/ios-xcframework/DerivedData/XCFrameworkScaffold/Build/Products/Debug-iphonesimulator/ReactCommon/ReactCommon.framework/Headers/CallbackWrapper.h' - Target 'ReactCommon' (project 'Pods') has copy command from '/Users/gio/Developer/a8c/gutenberg-mobile/ios-xcframework/Pods/ReactCommon/react/nativemodule/core/ReactCommon/CallbackWrapper.h' to '/Users/gio/Developer/a8c/gutenberg-mobile/ios-xcframework/DerivedData/XCFrameworkScaffold/Build/Products/Debug-iphonesimulator/ReactCommon/ReactCommon.framework/Headers/CallbackWrapper.h' ``` However, with this setup the build fails with: ``` /Users/gio/Developer/a8c/gutenberg-mobile/ios-xcframework/Pods/../../gutenberg/node_modules/react-native/React/FBReactNativeSpec/../../scripts/xcode/with-environment.sh: line 35: .xcode.env: command not found /Users/gio/Developer/a8c/gutenberg-mobile/ios-xcframework/Pods/../../gutenberg/node_modules/react-native/React/FBReactNativeSpec/../../scripts/xcode/with-environment.sh: line 35: node: command not found [Warning] You need to configure your node path in the environment. You can set it up quickly by running: echo 'export NODE_BINARY=' > .xcode.env in the ios folder. This is needed by React Native to work correctly. We fallback to the DEPRECATED behavior of finding . This will be REMOVED in a future version. You can read more about this here: https://reactnative.dev/docs/environment-setup#optional-configuring-your-environment /Users/gio/Developer/a8c/gutenberg-mobile/ios-xcframework/Pods/../../gutenberg/node_modules/react-native/React/FBReactNativeSpec/../../scripts/xcode/with-environment.sh: line 41: /scripts/find-node-for-xcode.sh: No such file or directory [Error] Could not find node. It looks like that the .xcode.env or .xcode.env.local ```
This way, users can override what CocoaPods does without modifying the codebase via the `.local` file.
Otherwise, we're getting a compilation failure. See wordpress-mobile/WordPress-iOS@eadad98#commitcomment-119894859
4f31ae2 to
c2bfebc
Compare
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
They will take place if the process runs with `HERMES_ENABLED` true.
27b232f to
91bacf5
Compare
…rnreanimated-2.17.0-no-hermes
This was referenced Jun 30, 2023
Contributor
|
iOS Ci jobs are passing with this workaround 🎊 (we can omit |
135dcb1 to
6f175c1
Compare
8d171f3 to
dbfac03
Compare
This was referenced Jul 3, 2023
Contributor
Author
|
@fluiddot sorry to hold you up. I've been investigating this branch for a good part of my day, starting from CI to run the tests when using the XCFramework built from 
The problem, as can be seen when using that version locally, is that Hermes cannot be found I think what happened is that the fix for that issue that I had implemented in b77ceee got lost when I ported over the work from #5908 to this PR. I'm working on addressing that... Apologies for the delay. |
Contributor
@mokagio No worries, let me know if I can help any how on this workaround 🙇 . I tried exploring part of my day building the WP-iOS app using Gutenberg locally, but no luck so far. For now, and for the sake of unblocking the iOS builds for the RN upgrade, I'd advocate focusing on the CI installable builds. After that, we could explore how to enable local builds. |
Contributor
Author
|
FYI, I am working on the said fixes in #5924
+1 |
Contributor
Author
|
Closing in favor of #5924 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #5908 but without Hermes, just to see how it works in Jetpack/WordPress.I disabled Hermes because adding it required some additional setup (see #5908) which I'm not sure I have worked out yet.This is the first build I get to compile and run successfully on my machine when integrated. A WordPress CI build is running here.
Update: I have builds that compile and on which I can load the editor for both implementations, with and without Hermes. I made whether to use engine configurable at build time with the
HERMES_ENABLEDenvironment variable. It's now on by default because my understanding is that is the preferred solution.