Skip to content

Release 1.85.1#5292

Merged
derekblank merged 7 commits into
trunkfrom
release/1.85.1
Dec 1, 2022
Merged

Release 1.85.1#5292
derekblank merged 7 commits into
trunkfrom
release/1.85.1

Conversation

@SiobhyB

@SiobhyB SiobhyB commented Nov 30, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Release for Gutenberg Mobile 1.85.1

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Change 1

The following error was displaying when uploading images to an existing Gallery block: If uploading to a gallery all files need to be image formats. The changes in this PR prevent that error from incorrectly popping up.

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

@SiobhyB SiobhyB mentioned this pull request Nov 30, 2022
Merged
@SiobhyB SiobhyB self-assigned this Nov 30, 2022
@SiobhyB SiobhyB mentioned this pull request Nov 30, 2022
Merged
1 task
@SiobhyB SiobhyB mentioned this pull request Nov 30, 2022
Merged
1 task
@SiobhyB SiobhyB marked this pull request as ready for review November 30, 2022 18:20
@SiobhyB SiobhyB requested a review from jhnstn November 30, 2022 18:21
@SiobhyB

SiobhyB commented Nov 30, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

🟢 New Changes (iOS)

Build: pr19689-716f973 from wordpress-mobile/WordPress-iOS#19689 (comment)
Device: iPhone XR, iOS 16.0.3

@SiobhyB

SiobhyB commented Nov 30, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

🟢 Writing Flow checklist (iOS)

Build: pr19689-716f973 from wordpress-mobile/WordPress-iOS#19689 (comment)
Device: iPhone XR, iOS 16.0.3

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@jhnstn

jhnstn commented Nov 30, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

🟢 New Changes (Android)

Build: pr17586-e6a27ee.apk
Device: Pixel 6 Android 13

@jhnstn

jhnstn commented Nov 30, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

🟢 Writing Flow checklist (Android)

Build: pr17586-e6a27ee.apk
Device: Pixel 6 Android 13

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@derekblank derekblank enabled auto-merge December 1, 2022 06:17
@derekblank derekblank merged commit 7e410e6 into trunk Dec 1, 2022
@derekblank derekblank deleted the release/1.85.1 branch December 1, 2022 06:59
@fluiddot

fluiddot commented Dec 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

@derekblank I noticed this PR was merged into trunk with some E2E tests failing 🤔. Please, we should be careful when enabling the auto-merge and verify that all PR checks succeed, especially because the Full (Release) (e.g. Test Android on Device - Full (Release)) checks are not required, which means that the auto-merge won't wait for them to be finished. Thanks!

@derekblank

derekblank commented Dec 2, 2022

Copy link
Copy Markdown
Contributor

@fluiddot Good call, I noticed that too after the auto-merge. In this case, do you think the E2E tests should be made to be required, or that we should just avoid auto-merging entirely?

@fluiddot

fluiddot commented Dec 2, 2022

Copy link
Copy Markdown
Contributor

In this case, do you think the E2E tests should be made to be required, or that we should just avoid auto-merging entirely?

Yeah, at least they should be required for release branches. Maybe we could create a branch rule for this case 🤔.

Regarding the use of auto-merge, I think we can still use it for regular PRs because we're not triggering the Full test suite jobs, but probably avoid it for release PRs due to this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhnstn jhnstn jhnstn approved these changes

Assignees

@SiobhyB SiobhyB

Labels

release-process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SiobhyB @jhnstn @fluiddot @derekblank