Skip to content

[RNMobile] Add 'Insert from URL' option to Video block#4941

Merged
derekblank merged 5 commits intotrunkfrom
rnmobile/add-url-option-to-video-block
Jun 10, 2022
Merged

[RNMobile] Add 'Insert from URL' option to Video block#4941
derekblank merged 5 commits intotrunkfrom
rnmobile/add-url-option-to-video-block

Conversation

@derekblank
Copy link
Copy Markdown
Contributor

Fixes gutenberg#41493 by adding the Insert from URL option to the Video block.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jun 9, 2022

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@derekblank derekblank changed the title Rnmobile/add url option to video block [RNMobile] Add 'Insert from URL' option to Video block Jun 9, 2022
@derekblank derekblank requested a review from dcalhoun June 9, 2022 11:59
@dcalhoun dcalhoun self-assigned this Jun 9, 2022
Copy link
Copy Markdown
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM! Approved via WordPress/gutenberg#41493 (review).

Before merging this PR, we should update the gutenberg ref to be the merge commit: WordPress/gutenberg@56df22d. After that is done, we are clear to merge this PR. Well done!

@dcalhoun dcalhoun assigned derekblank and unassigned dcalhoun Jun 9, 2022
@derekblank derekblank merged commit c1328f5 into trunk Jun 10, 2022
@derekblank derekblank deleted the rnmobile/add-url-option-to-video-block branch June 10, 2022 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants