Upload captured photo ios#494
Merged
SergioEstevao merged 3 commits intofeature/upload_captured_photo_androidfrom Jan 24, 2019
Merged
Upload captured photo ios#494SergioEstevao merged 3 commits intofeature/upload_captured_photo_androidfrom
SergioEstevao merged 3 commits intofeature/upload_captured_photo_androidfrom
Conversation
…oad_captured_photo_ios
etoledom
approved these changes
Jan 24, 2019
| callback(nil) | ||
| return | ||
| } | ||
| callback([mediaID, url]) |
Contributor
There was a problem hiding this comment.
Just an idea:
All the media events in the bridge look super similar. (onMediaLibraryPressed. onUploadMediaPressed, onCapturePhotoPressed)
Maybe we could merge them and send a flag to identify them?
Contributor
Author
There was a problem hiding this comment.
Just proposed that on the Android PR that has the bridge method for JS. I can also change the delegate here to make it a single method.
Contributor
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #471
This PR hooks the methods needed to get the device camera capture of media.