Change mediaId from String to int in bridge for media upload#487
Merged
mzorz merged 2 commits intofeature/upload_media_file_androidfrom Jan 23, 2019
Merged
Change mediaId from String to int in bridge for media upload#487mzorz merged 2 commits intofeature/upload_media_file_androidfrom
mzorz merged 2 commits intofeature/upload_media_file_androidfrom
Conversation
…rg and WP media library
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the block validation error when uploading media on Android, and matches media handling in Gutenberg and WP media library.
To test:
@SergioEstevao as chatted, I guess you have this covered on the iOS side, but mentioning you here and asking for review just in case (not needed if the change is obvious to you). Thanks!