Skip to content

[RNMobile] - Add optional wait in getBlockAtPosition#4734

Merged
fluiddot merged 4 commits intotrunkfrom
version-toolkit/gutenberg/rnmobile/add-optional-wait-to-getblockatposition
Apr 8, 2022
Merged

[RNMobile] - Add optional wait in getBlockAtPosition#4734
fluiddot merged 4 commits intotrunkfrom
version-toolkit/gutenberg/rnmobile/add-optional-wait-to-getblockatposition

Conversation

@wpmobilebot
Copy link
Copy Markdown
Collaborator

Related PRs

Description

This PR is generated by version-toolkit to downstream the changes for gutenberg submodule.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Apr 6, 2022

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@jostnes jostnes added the Testing Anything related to automated tests label Apr 6, 2022
@jostnes jostnes requested a review from fluiddot April 7, 2022 06:44
@fluiddot
Copy link
Copy Markdown
Contributor

fluiddot commented Apr 7, 2022

@jostnes heads up that one test failed on iOS after the latest changes: https://app.circleci.com/pipelines/github/wordpress-mobile/gutenberg-mobile/16922/workflows/5ddfa833-f4c5-4a83-8a67-aeec2b81f10d/jobs/92036/tests#failed-test-0

I don't think the failure is related to the changes so I went ahead and restart it.

Copy link
Copy Markdown
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#40078 (review).

NOTE: Before merging this PR, we have to update the Gutenberg reference with the merge commit of WordPress/gutenberg#40078.

@wpmobilebot wpmobilebot closed this Apr 8, 2022
@wpmobilebot wpmobilebot deleted the version-toolkit/gutenberg/rnmobile/add-optional-wait-to-getblockatposition branch April 8, 2022 01:52
@jostnes jostnes restored the version-toolkit/gutenberg/rnmobile/add-optional-wait-to-getblockatposition branch April 8, 2022 07:09
@jostnes jostnes reopened this Apr 8, 2022
@wpmobilebot wpmobilebot closed this Apr 8, 2022
@wpmobilebot wpmobilebot deleted the version-toolkit/gutenberg/rnmobile/add-optional-wait-to-getblockatposition branch April 8, 2022 07:12
@jostnes jostnes restored the version-toolkit/gutenberg/rnmobile/add-optional-wait-to-getblockatposition branch April 8, 2022 07:44
@fluiddot fluiddot reopened this Apr 8, 2022
@fluiddot
Copy link
Copy Markdown
Contributor

fluiddot commented Apr 8, 2022

@jostnes I managed to update the Gutenberg reference with the merge commit 🎊 , once the PR checks pass I'll merge it.

@fluiddot fluiddot merged commit f0990cf into trunk Apr 8, 2022
@fluiddot fluiddot deleted the version-toolkit/gutenberg/rnmobile/add-optional-wait-to-getblockatposition branch April 8, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing Anything related to automated tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants