[RNMobile] Update "add block" button style in default editor view#4705
Merged
SiobhyB merged 50 commits intoApr 13, 2022
Merged
Conversation
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
…efault-block-inserter-button
jhnstn
approved these changes
Apr 4, 2022
jhnstn
left a comment
Member
There was a problem hiding this comment.
Approved via WordPress/gutenberg#39726
…efault-block-inserter-button
…efault-block-inserter-button
…-inserter-button' of https://github.com/wordpress-mobile/gutenberg-mobile into version-toolkit/gutenberg/rnmobile/update/default-block-inserter-button
…efault-block-inserter-button
4 tasks
fluiddot
reviewed
Apr 12, 2022
Comment on lines
-161
to
-163
| <string name="gutenberg_native_failed_to_insert_audio_file" tools:ignore="UnusedResources">Failed to insert audio file.</string> | ||
| <string name="gutenberg_native_failed_to_insert_audio_file_please_tap_for_options" tools:ignore="UnusedResources">Failed to insert audio file. Please tap for options.</string> | ||
| <string name="gutenberg_native_failed_to_insert_media" tools:ignore="UnusedResources">Failed to insert media.</string> |
Contributor
There was a problem hiding this comment.
These strings were removed in WordPress/gutenberg#39694, so the change is valid 👍 .
fluiddot
approved these changes
Apr 12, 2022
fluiddot
left a comment
Contributor
There was a problem hiding this comment.
Approved via WordPress/gutenberg#39726 (review).
NOTE: We might consider updating the iOS bundle with the latest changes.
…-inserter-button' of https://github.com/wordpress-mobile/gutenberg-mobile into version-toolkit/gutenberg/rnmobile/update/default-block-inserter-button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs
Gutenberg:[RNMobile] Update "add block" button style in default editor view WordPress/gutenberg#39726 by @SiobhyBAndroid installable build:[DO NOT MERGE] [RNMobile] Update block inserter button WordPress-Android#16196iOS installable build:[DO NOT MERGE] [RNMobile] Update block inserter button WordPress-iOS#18233Description
This PR is generated by
version-toolkitto downstream the changes forgutenbergsubmodule. Please refer to the Gutenberg PR as the central PR with the most up-to-date description and testing steps for the proposed changes.