Reset the focused field state if a paragraph gets replaced with a non-editable block#421
Closed
mzorz wants to merge 2 commits intorelease/0.3from
Closed
Reset the focused field state if a paragraph gets replaced with a non-editable block#421mzorz wants to merge 2 commits intorelease/0.3from
mzorz wants to merge 2 commits intorelease/0.3from
Conversation
…ets replaced with a non-editable block
Contributor
Author
|
Closing in favor of #423 due to the reasons expressed in #423 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #415
The problem was that when we were replacing a Paragraph block, the
TextInputState.focusedFieldmember would still keep track of the now gone block, and thus the next time we tried to blur the supposedly "focused field" by callingTextInputState.blurTextInput( currentlyFocusedTextInput )the app would run into an error.This PR fixes that by resetting the focus (clearing it with
blur) when doing the replace, so there's no longer a reference to a node that doesn't exist anymore.To test:
Test the same with content, without content, in different parts, and also try the page break block.